Automate configuration #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfa_azure/helpers.py
Outdated
| t.append(task_id) | ||
| return t | ||
| tasks.append(task_id) | ||
| return tasks |
There was a problem hiding this comment.
this add_task() function shouldn't be changed. It's currently setup to return the string task_id name if it's just a single task that gets added and a list if it is multiple. Returning a string is necessary for the new automation functions
ryanraaschCDC
requested changes
Dec 20, 2024
* Update README.md Bulk of updates * Update README.md Added example workflow for helpers section and added some syntax fixes * Update README.md Added remaining functions from helpers.py * Update README.md Deleting duplicate line * bump version * bump version --------- Co-authored-by: Ryan Raasch <[email protected]>
* ariks fix * new version * precommit fixes
* Revert "Remove pre commit" This reverts commit 60e1c87. * Styler changes * renamed main to master
xop5
force-pushed
the
automate_configuration
branch
from
c300159 to
8515a82
Compare
cfa_azure/batch.py
Outdated
There was a problem hiding this comment.
this batch section was previously deleted but now it's back
cfa_azure/helpers.py
Outdated
| return task_id | ||
|
|
||
| tasks.append(task_id) | ||
| return tasks |
There was a problem hiding this comment.
this is still returning a list. We should just return task_id from this function and there's no need to append it to tasks. Check out the master branch for how it should work
ryanraaschCDC
approved these changes
Dec 23, 2024
|
please run pre-commit on the files before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.